Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheets-drawing): fix crash when editing text after inserting images and opening the sidebar #2586

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(sheets-drawing): fix crash when editing text after inserting images and opening the sidebar #2586

merged 1 commit into from
Jun 21, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jun 21, 2024

close https://github.com/dream-num/univer-pro/issues/1234

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 21, 2024
wzhudev
wzhudev approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jun 21, 2024
@jikkai jikkai merged commit 5536b05 into dev Jun 21, 2024
2 checks passed
@jikkai jikkai deleted the fix/sheets-images branch June 21, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jikkai @wzhudev